Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use yr.no as weather source #354

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Conversation

Erb3
Copy link
Contributor

@Erb3 Erb3 commented Nov 5, 2023

Todo:

  • Use yr as weather source
  • Optionally cache results using redis

Closes #352

Copy link

vercel bot commented Nov 5, 2023

@Erb3 is attempting to deploy a commit to the Noodle Team on Vercel.

A member of the Team first needs to authorize it.

@ixahmedxi
Copy link
Collaborator

Just some thoughts after quick review of this:

  • Could we possibly add emojis in the getFormattedWeatherDescription like at the start of each one, chatgpt would probably be helpful here.
  • Caching with redis sounds like a great idea!

Copy link

vercel bot commented Nov 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 8:14am

@ixahmedxi ixahmedxi marked this pull request as ready for review November 6, 2023 08:15
@ixahmedxi ixahmedxi merged commit ddf140b into noodle-run:main Nov 6, 2023
2 checks passed
@Erb3 Erb3 mentioned this pull request Nov 6, 2023
Erb3 added a commit to Erb3-forked/noodle-legacy that referenced this pull request May 14, 2024
* Use yr.no as weather source

* feat: adds emojis and more conditions

---------

Co-authored-by: Ahmed Elsakaan <[email protected]>
@Erb3 Erb3 deleted the erb3-yr branch May 14, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: replace openweather api with (https://developer.yr.no/)
2 participants